my life, it's ****ed.

[mywebradio12]

hi all

why does this piece of code not work :s
<?php
mysql_query("UPDATE `articles` SET likes = likes+'".$_SESSION['userid'].",' WHERE id = '".mysql_real_escape_string($_GET['id'])."'") or die('error liking an article lol sorry');
?>

what it needs to do is simple:
adding "<user id number>," to the existing table row "likes".

nvm: with the comma to separate the id's.

Thank you for your time in advance.

Kind Regards,
mywebradio12

[your_death_1994]

Do you see any errors when you ran this code?

and what is the term in bold? if its a variable shouldn't it be $likes or something.
likes = likes+'".$_SESSION['userid'].",'

Lol, im learning php, so yeah i don't know a lot.

[bdistler]

I ASSUME THIS IS A TEST PHP SCRIPT
AND WILL NOT BE INCORPORATE INTO YOUR SITE
UNTIL YOU HANDLE ERRORS AND TEST YOUR DATA
AND RESULTS IN THE APPROPRIATE WAY

I would do

$tempID = mysql_real_escape_string($_GET['id']) 

then use $tempID in the query

I would make up the query in a var and use it like

$query = "UPDATE `articles` SET likes =....."
$result = mysql_query($query) or die....... 

then to get the error info replace - starting at die with

... die ("error liking an article lol sorry<br />\n MySQL error ==>" . mysql_errno() . "<== : ==>" . mysql_error() . "<== <br />\n\$query ==>" . $query . "<==<br />\n "); 

others will be here to tell you to use PDO

[resty_rizal99]

how about change your code like this

// Get the current value of likes from articles with a match id of $_GET['id']
if(!$result = mysql_query('SELECT `likes` FROM `articles`  WHERE `id` = "'.mysql_real_escape_string($_GET['id']).'"')) die('Invalid query: ' . mysql_error());
$row = mysql_fetch_row($result);
$likes = $row[0];

// Update articles likes with the value of likes plus value of $_SESSION['userid']
mysql_query("UPDATE `articles` SET `likes` = '".($likes+$_SESSION['userid'])."' WHERE `id` = '".mysql_real_escape_string($_GET['id'])."'") or die('error liking an article lol sorry'); 

[gomarc]

Hello mywebradio12,

As long as the value of $_SESSION['userid'] is numeric, your query as posted works. Before the query, test this value to ensure its numeric.

I also suspect that server temporal issues may have affected your results.

Earlier today, I was having some connection issues with MySQL (my free account server is chopin) but all is working fine now.

As pointed out by bdistler, you should definitively move away from the old mysql extension. Please read this post by essellar: PHP to begin deprecation of ext/mysql -- start moving your development to PDO now

[misson]

Additionally:

• Use [php], [html] or [code] tags (as appropriate) when posting to separate and format code.
  
• Don't use die when outputting HTML. You'll get invalid HTML.
  
• Columns in relational tables should have scalar (aka "simple" or "atomic") values, not compound values (aka "repeating groups"). A comma-separated list is a compound value. This is a basic property of RDBs called "first normal form". Instead, use a table to represent the relationship:
  

  CREATE TABLE likes (
      `article` INT UNSIGNED NOT NULL,
      `user` INT UNSIGNED NOT NULL,
      UNIQUE KEY (`article`, `user`),
      FOREIGN KEY `article` REFERENCES `articles` (`id`),
      FOREIGN KEY `user` REFERENCES `users` (`id`)
  ) Engine=InnoDB;

  To get the users that like an article, join the "articles" and "users" tables using the "likes" table.

[theone48]

Yikes, this is a temperamental thread. What does death have to do with programming?

Oh, maybe, 'die' has some alternative cyber meaning for programming function.

[lemon-tree]

Yikes, this is a temperamental thread. What does death have to do with programming?

Oh, maybe, 'die' has some alternative cyber meaning for programming function.

The die() function causes the currently running script to end execution. If you don't like that terminology, you can use exit() instead. A quick search of the PHP manual would have told you precisely this.

[theone48]

The die() function causes the currently running script to end execution. If you don't like that terminology, you can use exit() instead. A quick search of the PHP manual would have told you precisely this.

Thanks, thought it had something to do with programming. Sorry for the stupid question, but I don't even know what 'PHP' is.