Results 1 to 7 of 7

Thread: Problem with login script

  1. #1
    accoun80 is offline x10Hosting Member
    Join Date
    Jun 2012
    Posts
    7

    Question Problem with login script

    I'm trying to set up a simple login system. Every time, I enter the correct credentials it tells me that they're wrong. What can I do to fix it?
    This is the full code:
    of the login form:
    PHP Code:
    <html>
     <
    head>
      <
    title>Login Test</title>
     </
    head>
     <
    body>
      <
    h2>Login Test</h2>
      <
    form method="post"  action="login_test/login.php">
      <
    p>Username: <input type="text" name="Username"/></p>
      <
    p>Password: <input type="password" name="Password"/></p
      <
    p><input type="submit" value="Login" /></p>
      </
    form>
     </
    body>
    </
    html
    ;
    of login_test/login.php:
    PHP Code:
    <?php

     ob_start
    ();
     
    $host="localhost"
    $username=""// Mysql username 
    $password=""// Mysql password 
    $db_name=""// Database name 
    $tbl_name=""// Table name 


    // Connect to server and select databse.
     
    mysql_connect("$host""$username""$password")or die("cannot connect"); 
     
    mysql_select_db("$db_name")or die("cannot select DB");


    // Define $myusername and $mypassword 
     
    $myusername=$_POST['myusername']; 
     
    $mypassword=$_POST['mypassword']; 


    // To protect MySQL injection (more detail about MySQL injection)
     
    $myusername stripslashes($myusername);
     
    $mypassword stripslashes($mypassword);
     
    $myusername mysql_real_escape_string($myusername);
     
    $mypassword mysql_real_escape_string($mypassword);

    $sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
     
    $result=mysql_query($sql);


    // Mysql_num_row is counting table row
     
    $count=mysql_num_rows($result);

    // If result matched $myusername and $mypassword, table row must be 1 row

    if($count==1){

    // Register $myusername, $mypassword and redirect to file "login_success.php"
     
    session_register("myusername");
     
    session_register("mypassword"); 
     
    header("location:status.php");
     }
     else {
     echo 
    "Wrong Username or Password";
     }

    ob_end_flush();
     
    ?>
    .
    Please help would be greatly appreciated.

  2. #2
    mraz is offline x10Hosting Member
    Join Date
    Jul 2012
    Posts
    95

    Re: Problem with login script

    i think your mistake is linking the submitted data on the form does not match with the validation script.

    try changing like below so that it matches with your validation script.

    My PHP is kinda rusty anyways so i'm here to learn as well..

    PHP Code:
      <p>Username: <input type="text" name="myusername" id="myusername"/></p>
      <
    p>Password: <input type="password" name="mypassword" id="mypassword"/></p

    PHP Code:
    // Define $myusername and $mypassword 
     
    $myusername=$_POST['myusername']; 
     
    $mypassword=$_POST['mypassword']; 

  3. #3
    misson is offline x10 Spammer
    Join Date
    Mar 2008
    Location
    Libertatia
    Posts
    2,573

    Re: Problem with login script

    @accoun80: Read the following, as your script has many of the same issues:


    Partial list of issues to look for:
    • outdated mysql extension
    • md5 considered broken
    • no password salt
    • or die
    • SELECT *
    • session fixation vulnerability
    • missing <label> elements in form
    • tight coupling of separate concerns
    • DB connection handled in main script


    Also, session_register is deprecated in PHP 5.3 and removed in 5.4. Use session_start, session_regenerate_id, $_SESSION.
    Last edited by misson; 07-15-2012 at 03:24 PM.
    Be sure to read all pages linked in this post; they have further information that should prove useful. When asking for help, make sure you follow Jon Skeet's and Eric Raymond's guidelines for prompt, accurate responses. Please answer any questions I ask; they're not rhetorical (probably). Any posted code is intended as illustrative example, rather than a solution to your problem to be copied without alteration. Study it to learn how to write your own solution.
    Misson, not Mission.

  4. #4
    accoun80 is offline x10Hosting Member
    Join Date
    Jun 2012
    Posts
    7

    Question Re: Problem with login script

    Can someone give me a link for a tutorial that works. please? I have been trying different ones for ages now and not one has worked.

  5. #5
    essellar's Avatar
    essellar is offline Community Advocate
    Join Date
    Feb 2010
    Location
    Toronto, Ontario, CA
    Posts
    1,682

    Re: Problem with login script

    Did you read the links misson posted? If you follow the one titled "Creating User Accounts", you'll find a link to a decent registration/login script at Github by callumacrae. Apart from the fact that it emails passwords in clear text to the user (never do that; email is too vulnerable), it's not at all bad from either a security or a code-quality standpoint. The whys and wherefores are in a couple of big long postings in that thread and in "Problem with encrypting passwords".
    “Beware of bugs in the above code; I have only proved it correct, not tried it.” --Donald Knuth
    "It was as if its architects were given a perfectly good hammer and gleefully replied, 'neat! With this hammer, we can build a tool that can pound in nails.'" -- Alex Papadimoulis (on TheDailyWTF.com)

  6. #6
    misson is offline x10 Spammer
    Join Date
    Mar 2008
    Location
    Libertatia
    Posts
    2,573

    Re: Problem with login script

    About the only thing I have to add is that if you're planning on writing a login or account system for your site, stop. The only reason to write your own is for self-education, and whatever results shouldn't be used on a production site. Systems already exist that will be more secure than whatever you come up with. SSO (single sign-on) looks promising. Better still would be to use something like OpenID.
    Last edited by misson; 07-17-2012 at 03:26 AM.
    Be sure to read all pages linked in this post; they have further information that should prove useful. When asking for help, make sure you follow Jon Skeet's and Eric Raymond's guidelines for prompt, accurate responses. Please answer any questions I ask; they're not rhetorical (probably). Any posted code is intended as illustrative example, rather than a solution to your problem to be copied without alteration. Study it to learn how to write your own solution.
    Misson, not Mission.

  7. #7
    accoun80 is offline x10Hosting Member
    Join Date
    Jun 2012
    Posts
    7

    Question Re: Problem with login script

    Quote Originally Posted by misson View Post
    About the only thing I have to add is that if you're planning on writing a login or account system for your site, stop. The only reason to write your own is for self-education, and whatever results shouldn't be used on a production site. Systems already exist that will be more secure than whatever you come up with. SSO (single sign-on) looks promising. Better still would be to use something like OpenID.
    I need a login system where people don't register. It will work like a network only people with login and password will be able to see it. Please someone help.

Similar Threads

  1. Login script
    By kwrat1497 in forum Scripts, 3rd Party Apps, and Programming
    Replies: 2
    Last Post: 01-01-2012, 08:11 PM
  2. PHP - Login Script
    By nerdpowah23 in forum Scripts, 3rd Party Apps, and Programming
    Replies: 2
    Last Post: 06-24-2011, 09:10 PM
  3. php login script
    By matt1213 in forum Scripts, 3rd Party Apps, and Programming
    Replies: 3
    Last Post: 12-03-2008, 08:31 AM
  4. Need Login Script- Will pay
    By Conmiro in forum Classifieds
    Replies: 4
    Last Post: 08-07-2008, 11:34 AM
  5. PHP login script
    By xunhandmex in forum Scripts, 3rd Party Apps, and Programming
    Replies: 8
    Last Post: 05-26-2005, 07:56 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
dedicated servers