script help

[CascadesAdmin]

I need help with this code:

Using WHOLE new code, still need help

<?
//Database Information

$dbhost = "localhost";
$dbname = "cascades_sope1";
$dbuser = "cascades_sope1";
$dbpass = "hiimbob";

//Connect to database

mysql_connect ( $dbhost, $dbuser, $dbpass)or die("Could not connect: 

".mysql_error());
mysql_select_db($dbname) or die(mysql_error());
//end connecting to db


//Storing Names
//Secure (md5)

$name = $_POST['name'];
$email = $_POST['email'];    
$username = $_POST['username'];
$password = md5($_POST['password']);
$emailpass = ($_POST['password']);
//end secure
//end storing names

//checking if username already exists

$checkuser = mysql_query("SELECT username FROM users WHERE 

username='$username'"); 

$username_exist = mysql_num_rows($checkuser);

if ($username_exist > 0){
   echo() "I'm sorry but the username you entered has already been taken. 

 Please pick another one.";
    unset($username);
    include 'register.html';
    exit();
}
//end check

//registrartion complete

$query = "INSERT INTO users (name, email, username, password)
VALUES('$name', '$email', '$username', '$password')";
mysql_query($query) or die(mysql_error());
mysql_close());

echo() "You have successfully Registered";

$yoursite = &#8216;fanclub.cascades.exofire.net/’;
$webmaster = &#8216;Cascades Admin’;
$youremail = &#8216;noreply@cascades.exofire.net’;

$subject = "You have successfully registered at $yoursite...";
$message = "Dear $name, you are now registered at our web site.  
         
                 PLEASE DO NOT REPLY TO THIS MESSAGE   

    To login, simply go to our web page and enter in the following 

details in the login form:
    Username: $username
    Password: $emailpass
    
    Please print this information out and store it for future 

reference.
    
    Thanks,
    $webmaster";
    
mail($email, $subject, $message, "From: $yoursite 

<$youremail>\nX-Mailer:PHP/" . phpversion());
    
echo() "Your information has been mailed to your email address.";


?>

get this error message when I try to register to test

Parse error: syntax error, unexpected ')' in /home/cascades/public_html/fanclub/register.php on line 34

[Chris Z]

try this:

<?php 
$database[dbserver]="localhost"; 
$database[dbuser]="cascades_sope1"; 
$database[dbname]="cascades_sope1"; 
$database[dbpass]="Removed For Obvious Reasons"; 
$table ="users"; 
 
$connect = mysql_connect($database[dbserver], $database[dbuser], $database[dbpass]); 
 
$select= mysql_select_db($database[dbname]); 
?>

or this:

<?php 
$database['dbserver']="localhost"; 
$database['dbuser']="cascades_sope1"; 
$database['dbname']="cascades_sope1"; 
$database['dbpass']="Removed For Obvious Reasons"; 
$table ="users"; 
 
$connect = mysql_connect($database['dbserver'], $database['dbuser'], $database['dbpass']); 
 
$select= mysql_select_db($database['dbname']); 
?>

[Kansy]

mmm I think the first error is because an error with the DB login and user names.. try to delete your DB if its empty if not do a backup and create it another time... and chek again and if you need in the new DB upload all the tabls you have in the old

I can't answer to the second error... Im sorry I have no Idea

[Zenax]

Chris Z is right on the connection script. You should leave the db server at local host:

<?php 
$database['dbserver'] = 'localhost'; 
$database['dbuser'] = 'cascades_sope1'; 
$database['dbname'] = 'cascades_sope1'; 
$database['dbpass'] = 'Removed For Obvious Reasons'; 
$table = 'users'; 
 
$connect = mysql_connect($database['dbserver'], $database['dbuser'], $database['dbpass']); 
 
$select= mysql_select_db($database['dbname']); 
?>

As for your login script, I use the following:

<?php
session_start();

// Require once the DB script
   require_once ($_SERVER['DOCUMENT_ROOT']. '/config.php');

   if ($_POST['loginSubmit']) {
      // You *always!* need to validate user-supplied data when using it in MySQL queries!!
      // This isn't 100% secure, but it's definitely better than having nothing and being vulnerable to SQL injection.
      if(get_magic_quotes_gpc()) {
         if(ini_get('magic_quotes_sybase')) {
             $username = str_replace("''", "'", $_POST['username']);
             $password = str_replace("''", "'", $_POST['password']);
         } else {
             $username = stripslashes($_POST['username']);
             $password = stripslashes($_POST['password']);
         }
      } else {
          $username = $_POST['username'];
          $password = $_POST['password'];
      }
      $username = mysql_real_escape_string($username);
      $password = mysql_real_escape_string($password);
      
      $check = mysql_query("SELECT * FROM `users` WHERE `users` = '$username' and `password` = '$password' LIMIT 1");
      
      // Counting the table row
      // If the result is matched then $username, $password must be row 1
      $count = @mysql_num_rows($check);
      
      // Logged in!
      if ($count == (int) 1) {
         $_SESSION['site_username'] = $username;
         $_SESSION['site_password'] = $password;
         
         echo '<link rel="stylesheet" href="style.css" type="text/css" />
<div align="center">Welcome '. $_SESSION['site_username'] .'. You are now logged in!<br /><a href="members">Click Here to Continue</a></div>';

         $_GET['do'] = 'manualUnset';
         // Do whatever ?
      }
      else {
         echo 'Error: Wrong username or password specified. <br />';
      }
   }

   // If $_GET['do'] is set to 'manualUnset', do not show login form, user already logged in.
   switch ($_GET['do']) {
      case 'manualUnset':
         break;
      default:
?>
<link rel="stylesheet" href="style.css" type="text/css" />
    <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
    <table width="90%" border="0" cellspacing="0" cellpadding="5">
     <tr>
      <td>Username:</td>
      <td>Password:</td>
     </tr>
     <tr>
      <td><input type="text" name="username" /></td>
      <td><input type="password" name="password" /> &nbsp; <input name="loginSubmit" type="submit" value="Login" class="button" /></td>
     </tr>
    </table>
    </form>
<?php
      break;
   }
?>

If you have any more problems please let us know. Obviously the script I use is tailored to my needs, and if you want to use it you are more than welcome. All you would have to do is change around the names used in the script.

Regards,
Zenax

[CascadesAdmin]

whole new script, whole new problem...

[Cubeform]

PHP error messages are always so unhelpful.

Try this: If line 34 is the line with

   echo() "I'm sorry but the username you entered has already been taken. 

try getting rid of the parentheses; you don't need them anyway. Do the same every time you use echo in your script.

[CascadesAdmin]

no because the parentheses are needed in php4. If you search on google for echo php syntax, it will tell you that the correct way is echo()

[t2t2t]

http://ee2.php.net/manual/en/function.echo.php

echo() is not actually a function (it is a language construct), so you are not required to use parentheses with it. echo() (unlike some other language constructs) does not behave like a function, so it cannot always be used in the context of a function. Additionally, if you want to pass more than one parameter to echo(), the parameters must not be enclosed within parentheses.

Believe in the manual! + you have totally wrong syntax! (The text has to be ("here") not () "here"
Also, for line breaks, add <br />

[Chris Z]

well if you need that, then it's supposed to be:

echo('I\'m sorry but the username you entered has already been taken'); 

[Zenax]

I have always used:

echo 'I\'m sorry but the username you entered has already been taken!'; 

I never use parenthesis. I used too, but my scripts work without them, so I do not consider it a fundamental thing to include!